Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment LogRootV1 fields properly #2546

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Comment LogRootV1 fields properly #2546

merged 3 commits into from
Jun 17, 2021

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Jun 17, 2021 •
edited
Loading

@pav-kv pav-kv requested review from pphaneuf and NatalieDoduc June 17, 2021 10:19
@pav-kv pav-kv requested a review from a team as a code owner June 17, 2021 10:19
@pav-kv pav-kv force-pushed the deprecate_field branch from 8ee5b11 to 2d8285e Compare June 17, 2021 10:22
AlCutter
AlCutter approved these changes Jun 17, 2021
View reviewed changes
types/logroot.go Outdated Show resolved Hide resolved
NatalieDoduc
NatalieDoduc approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@NatalieDoduc NatalieDoduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for this!

@pav-kv pav-kv merged commit ec5e410 into google:master Jun 17, 2021
@pav-kv pav-kv deleted the deprecate_field branch June 17, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

@NatalieDoduc NatalieDoduc NatalieDoduc approved these changes

@pphaneuf pphaneuf Awaiting requested review from pphaneuf

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pav-kv @AlCutter @NatalieDoduc @googlebot