storage: Remove ReadOnlyLogTX interface #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
force-pushed
the
remove_read_only_log_tx
branch
from
2a7670c to
2a5a98b
Compare
pphaneuf
reviewed
Jun 18, 2021
pav-kv
force-pushed
the
remove_read_only_log_tx
branch
2 times, most recently
from
99a7d04 to
ab287d2
Compare
The only useful method from this interface, GetActiveLogIDs, was moved to LogStorage.
pav-kv
force-pushed
the
remove_read_only_log_tx
branch
from
ab287d2 to
91c737e
Compare
pphaneuf
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only used method of
ReadOnlyLogTXwasGetActiveLogIDs. This change moves thismethod directly to the
LogStorageinterface without affecting transaction semantics.Checklist