Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move and unexport layout and Suffix code #2583

Merged
merged 7 commits into from
Jul 20, 2021
Merged

Move and unexport layout and Suffix code #2583

merged 7 commits into from
Jul 20, 2021

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Jul 19, 2021

The layout.go and suffix.go files are only consumed by the cache package.
This change moves both types to this package, and unexports them.

Checklist

@pav-kv pav-kv requested a review from a team as a code owner July 19, 2021 17:44
@pav-kv
Copy link
Contributor Author

pav-kv commented Jul 19, 2021

Review commit-by-commit.

@pav-kv
Copy link
Contributor Author

pav-kv commented Jul 20, 2021

PTAL

@pav-kv pav-kv merged commit 0654e78 into google:master Jul 20, 2021
@pav-kv pav-kv deleted the mv_layout_and_suffix branch July 20, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

@pphaneuf pphaneuf Awaiting requested review from pphaneuf

@Martin2112 Martin2112 Awaiting requested review from Martin2112

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pav-kv @AlCutter @googlebot