Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make countFromInformationSchema function compatible with MySQL 8 #2651

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions quota/mysqlqm/mysql_quota.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import (
"context"
"database/sql"
"errors"
"fmt"
"strconv"

"github.com/google/trillian/quota"
)
Expand Down Expand Up @@ -97,6 +99,10 @@ func (m *QuotaManager) countUnsequenced(ctx context.Context) (int, error) {
}

func countFromInformationSchema(ctx context.Context, db *sql.DB) (int, error) {
// turn off statistics caching for MySQL 8
if err := turnOffInformationSchemaCache(ctx, db); err != nil {
return 0, err
}
// information_schema.tables doesn't have an explicit PK, so let's play it safe and ensure
// the cursor returns a single row.
rows, err := db.QueryContext(ctx, countFromInformationSchemaQuery, "Unsequenced", "BASE TABLE")
Expand Down Expand Up @@ -124,3 +130,29 @@ func countFromTable(ctx context.Context, db *sql.DB) (int, error) {
}
return count, nil
}

// turnOffInformationSchemaCache turn off statistics caching for MySQL 8
// To always retrieve the latest statistics directly from the storage engine and bypass cached values, set information_schema_stats_expiry to 0.
// See https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_information_schema_stats_expiry
func turnOffInformationSchemaCache(ctx context.Context, db *sql.DB) error {
opt := "information_schema_stats_expiry"
res := db.QueryRowContext(ctx, "SHOW VARIABLES LIKE '%"+opt+"%'")
var none, expiry string
err := res.Scan(&none, &expiry)
if err != nil {
if errors.Is(err, sql.ErrNoRows) {
return nil
}

return fmt.Errorf("Failed to get variable %q: %v", opt, err)
}

exp, err := strconv.Atoi(expiry)
if err != nil || exp != 0 {
if _, err := db.ExecContext(ctx, "SET SESSION "+opt+"=0"); err != nil {
return fmt.Errorf("Failed to set variable %q: %v", opt, err)
}
}

return nil
}