Remove the code for signing log roots if the last one is too old. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is leftover from when we thought app layers wouldn't have their own storage. I don't think it's being used and probably doesn't do what we need anyway.
codingllama
approved these changes
Dec 13, 2016
|
Not so fast! This prevents a size zero root being created if none exist, which breaks the integration test. Needs more thought on how this should work. Should maybe pass a "no root" error back to the caller. |
Could be better to move this to log create API when we write it. Then we can assume a root exists and raise an error if it doesn't. TODO added.
codingllama
approved these changes
Dec 13, 2016
daviddrysdale
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is leftover from when we thought app layers wouldn't have their own storage. I don't think it's being used and probably doesn't do what we need anyway.