Remake dumplib into integration test #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no need to look at all commits, can just review the last state. Commits in this PR were iteratively deleting bit by bit, so that I didn't miss anything important. |
jiggoha
reviewed
Apr 22, 2022
jiggoha
reviewed
Apr 24, 2022
jiggoha
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dumplibwas a tool which created an in-memory log storage of a particular size,and printed its contents with various flags. The useful bit of this tool was a "golden"
unit test which checks regressions on the
SubtreeProtoformat in storage.This change removes the tool, refactors the test, and places it in
integration/format.Checklist