Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache: Set a fixed tile height of 8 #2726

Merged
merged 2 commits into from
Apr 29, 2022
Merged

cache: Set a fixed tile height of 8 #2726

merged 2 commits into from
Apr 29, 2022

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Apr 28, 2022

This change reflects the status quo.

@pav-kv pav-kv requested a review from a team as a code owner April 28, 2022 17:50
@pav-kv pav-kv requested a review from roger2hk April 28, 2022 17:50
mhutchinson
mhutchinson approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to the changelog that this check is now more strict. It may well be enforced elsewhere, but I think no harm in having a line in the release notes clearly calling this type of additional check out.

@pav-kv pav-kv removed the request for review from roger2hk April 29, 2022 15:22
@pav-kv pav-kv merged commit 241204c into google:master Apr 29, 2022
@pav-kv pav-kv deleted the fixed_tile_height branch April 29, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pav-kv @mhutchinson