Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont store ephemeral nodes #2782

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Dont store ephemeral nodes #2782

merged 5 commits into from
Jul 27, 2022

Conversation

jiggoha
Copy link
Contributor

@jiggoha jiggoha commented Jul 25, 2022 •
edited
Loading

This CL is a copy of #2741, with the addition of updating the CHANGELOG.md.

Checklist

@jiggoha jiggoha marked this pull request as ready for review July 25, 2022 16:43
@jiggoha jiggoha requested a review from a team as a code owner July 25, 2022 16:43
@jiggoha jiggoha requested review from roger2hk and mhutchinson July 25, 2022 16:43
mhutchinson
mhutchinson approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval with the comment addressed 👍

@jiggoha jiggoha merged commit 89176c5 into master Jul 27, 2022
@jiggoha jiggoha deleted the dont_store_ephemeral_nodes branch July 27, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

@roger2hk roger2hk Awaiting requested review from roger2hk roger2hk is a code owner automatically assigned from google/trillian-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiggoha @mhutchinson