WIP: Add initial schema and storage provider for CockroachDB #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
changed the title
JAORMX
force-pushed
the
crdb
branch
4 times, most recently
from
0702e94 to
96d85a7
Compare
|
You can make use of the draft pull request if it is not yet ready for review. |
JAORMX
force-pushed
the
crdb
branch
3 times, most recently
from
ec49003 to
9851984
Compare
This creates an initial schema for CRDB by mirroring a lot of the existing constructs from the MySQL storage provider. It also adds scripts and test code to run unit and integration tests with CockRoachDB While this lead to a lot of code duplication, the intention is to address that in a separate PR in order to keep the work separated into logical batches. Doing all the refactoring to create common constructs for SQL backends would lead to a patch too big for folks to review in a reasonable time and would create more risk. The plan, thus, is as follows: [x] Create CRDB storage provider (this PR). [ ] Abstract SQL admin storage to its own package. [ ] Abstract Statement cache into its own package. [ ] Abstract (Log)Tree Transaction code into its own package. This way, we could have re-usable parts for other SQL providers. Signed-off-by: Juan Antonio Osorio <[email protected]>
|
superceded by #2834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an initial schema for CRDB by mirroring a lot of the
existing constructs from the MySQL storage provider. It also adds
scripts and test code to run unit and integration tests with CockRoachDB
While this lead to a lot of code duplication, the intention is to
address that in a separate PR in order to keep the work separated into
logical batches. Doing all the refactoring to create common constructs
for SQL backends would lead to a patch too big for folks to review in a
reasonable time and would create more risk.
The plan, thus, is as follows:
This way, we could have re-usable parts for other SQL providers.
Checklist