Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of rand.Seed #2918

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Remove use of rand.Seed #2918

merged 1 commit into from
Feb 21, 2023

Conversation

AlCutter
Copy link
Member

rand.Seed is deprecated as of go1.20, but I also suspect that setting this seed didn't do what it was intended to; it's likely this was intended to control the pseudo random data producing the certs to be logged in the integration test, but that uses crypto/rand internally which is unaffected by the seed in math/rand.

Checklist

@AlCutter AlCutter requested a review from roger2hk February 21, 2023 12:06
@AlCutter AlCutter requested a review from a team as a code owner February 21, 2023 12:06
@AlCutter AlCutter merged commit 710a1e1 into google:master Feb 21, 2023
@AlCutter AlCutter deleted the well_that_was_random branch February 21, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger2hk roger2hk roger2hk approved these changes

Assignees

@roger2hk roger2hk

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlCutter @roger2hk