mysql: check for error when getting subtrees #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
mhutchinson
approved these changes
Oct 31, 2023
|
@jsha can you rebase this on top of latest master and re-push? cloudbuild is failing some bazel checks that haven't been in this repo for some time. Your parent commit is currently: |
treeTX.getSubtrees iterates over a set of rows from `database/sql`, but it was failing to check the error status after exiting the for loop that iterates over them. On our log deployment, this is causing mistaken error messages of `preload did not get all tiles` when the real error should be propagated from mysql (in our case, max_statement_time exceeded).
jsha
force-pushed
the
close-those-rows
branch
from
8bfafab to
77e9d47
Compare
|
Done, thanks! |
|
/gcbrun |
|
Thanks! |
2 tasks
roger2hk
added a commit
to roger2hk/trillian
that referenced
this pull request
Nov 1, 2023
roger2hk
added a commit
that referenced
this pull request
Nov 1, 2023
* Update CHANGELOG.md for v1.5.3 release * Add /pull/3173 in CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
treeTX.getSubtrees iterates over a set of rows from
database/sql, but it was failing to check the error status after exiting the for loop that iterates over them.On our log deployment (Let's Encrypt Oak), this is causing mistaken error messages of
preload did not get all tileswhen the real error should be propagated from mysql (in our case, max_statement_time exceeded).We're in the middle of trying to remediate a significant availability from for get-sth-consistency, and getting this landed and deployed would help eliminate a source of noise in our investigation.