chore: relax go directive to permit 1.22.x #3713
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting this to 1.22.7 requires all consumers to be building with the 1.22.7 or newer release of Go 1.22 and to update their own go.mod accordingly — this seems unnecessarily restrictive for a library module, particularly as the code itself doesn't currently use any modern language constructs and builds fine even with older Go versions. Instead set the go directory to 1.22.0 and use the toolchain directive to recommend the latest 1.22.x when building locally. Signed-off-by: Dominic Evans <[email protected]>
|
/gcbrun |
|
Thanks @dnwe, good call. |
AlCutter
approved these changes
Jan 9, 2025
|
@AlCutter thanks Al — would you be happy to cut a v1.7.1 so I can adopt it in some other modules? |
Sure! |
dnwe
added a commit
to dnwe/certificate-transparency-go
that referenced
this pull request
Jan 9, 2025
Setting this to 1.22.7 requires all consumers to be building with the 1.22.7 or newer release of Go 1.22 and to update their own go.mod accordingly — this seems unnecessarily restrictive for a library module, particularly as the code itself doesn't currently use any modern language constructs and builds fine even with older Go versions. Instead set the go directive to 1.22.0 and use the toolchain directive to recommend the latest 1.22.x when building locally. Note: this also upgrade google/trillian to v1.7.1 in order to pull in google/trillian#3713 which is what allows the go directive to be relaxed here. Signed-off-by: Dominic Evans <[email protected]>
2 tasks
AlCutter
pushed a commit
to google/certificate-transparency-go
that referenced
this pull request
Jan 9, 2025
Setting this to 1.22.7 requires all consumers to be building with the 1.22.7 or newer release of Go 1.22 and to update their own go.mod accordingly — this seems unnecessarily restrictive for a library module, particularly as the code itself doesn't currently use any modern language constructs and builds fine even with older Go versions. Instead set the go directive to 1.22.0 and use the toolchain directive to recommend the latest 1.22.x when building locally. Note: this also upgrade google/trillian to v1.7.1 in order to pull in google/trillian#3713 which is what allows the go directive to be relaxed here. Signed-off-by: Dominic Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this to 1.22.7 requires all consumers to be building with the 1.22.7 or newer release of Go 1.22 and to update their own go.mod accordingly — this seems unnecessarily restrictive for a library module, particularly as the code itself doesn't currently use any modern language constructs and builds fine even with older Go versions.
Instead set the go directive to 1.22.0 and use the toolchain directive to recommend the latest 1.22.x when building locally.
Checklist