Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable certificate-transparency-go integration tests #822

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

codingllama
Copy link
Contributor

Temporary until certificate-transparency-go vendors its dependencies, at
which point Travis should work again

Temporary until certificate-transparency-go vendors its dependencies, at
which point Travis should work again
Copy link
Contributor

@Martin2112 Martin2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly not much point waiting for the tests.

@codingllama
Copy link
Contributor Author

Tests should be green, otherwise the fix failed. :)

Feel free to merge before me if I take too long.

@codecov-io
Copy link

codecov-io commented Sep 8, 2017

Codecov Report

Merging #822 into master will increase coverage by 10.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #822       +/-   ##
===========================================
+ Coverage   53.47%   63.69%   +10.21%     
===========================================
  Files           7       92       +85     
  Lines         374     7037     +6663     
===========================================
+ Hits          200     4482     +4282     
- Misses        156     2156     +2000     
- Partials       18      399      +381
Impacted Files Coverage Δ
trillian/testdata/signer.go
trillian/ctfe/handlers.go
trillian/util/timesource.go
asn1/common.go
jsonclient/client.go
types.go
signatures.go
docs/storage/commit_log/simkafka/kafka.go 84.78% <0%> (ø)
storage/mysql/admin_storage.go 73.92% <0%> (ø)
quota/kind_string.go 50% <0%> (ø)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1af48...3b54c31. Read the comment docs.

@codingllama codingllama merged commit 0a7397d into google:master Sep 8, 2017
@codingllama codingllama deleted the ctgo-disable branch September 8, 2017 15:29
daviddrysdale added a commit to daviddrysdale/trillian that referenced this pull request Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants