address diagnostics and update to a more recent package:lints (#304)

* address diagnostics and update to a more recent package:lints * Update CHANGELOG.md Co-authored-by: Kevin Moore <[email protected]> --------- Co-authored-by: Kevin Moore <[email protected]>
google · Oct 2, 2024 · aa0165f · aa0165f
1 parent b181c9e
commit aa0165f
Show file tree

Hide file tree

Showing 16 changed files with 31 additions and 9 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -40,7 +40,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        sdk: [3.0.0, stable, dev]
+        sdk: [3.1, stable, dev]
     steps:
     - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
     - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
@@ -66,7 +66,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        sdk: [3.0.0, stable, dev]
+        sdk: [3.1, stable, dev]
     steps:
     - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
     - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
-## 3.0.4-wip
+## 3.0.4
 
-* Require Dart 3.0.
+* Require Dart 3.1.
 
 ## 3.0.3
 

diff --git a/lib/src/common/utils.dart b/lib/src/common/utils.dart
@@ -12,7 +12,5 @@ WebDriverHandler getHandler(WebDriverSpec spec) {
       return W3cWebDriverHandler();
     case WebDriverSpec.Auto:
       return InferWebDriverHandler();
-    default:
-      throw UnsupportedError('Unexpected web driver spec: $spec.');
   }
 }
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,12 +1,12 @@
 name: webdriver
-version: 3.0.4-wip
+version: 3.0.4
 description: >-
   Provides WebDriver bindings for Dart. Supports WebDriver JSON interface and
   W3C spec. Requires the use of WebDriver remote server.
 repository: https://github.com/google/webdriver.dart
 
 environment:
-  sdk: ^3.0.0
+  sdk: ^3.1.0
 
 dependencies:
   matcher: ^0.12.10
@@ -16,5 +16,5 @@ dependencies:
 
 dev_dependencies:
   archive: ^3.3.0
-  lints: ^3.0.0
+  lints: ^4.0.0
   test: ^1.16.0
diff --git a/test/firefox_alert_test.dart b/test/firefox_alert_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_command_event.dart b/test/firefox_command_event.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_cookies_test.dart b/test/firefox_cookies_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_navigation_test.dart b/test/firefox_navigation_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_target_locator_test.dart b/test/firefox_target_locator_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_timeouts_test.dart b/test/firefox_timeouts_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_w3c_basic_sync_test.dart b/test/firefox_w3c_basic_sync_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_w3c_keyboard_test.dart b/test/firefox_w3c_keyboard_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_w3c_mouse_test.dart b/test/firefox_w3c_mouse_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_web_driver_test.dart b/test/firefox_web_driver_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_web_element_test.dart b/test/firefox_web_element_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 import 'package:webdriver/sync_core.dart';
 

diff --git a/test/firefox_window_test.dart b/test/firefox_window_test.dart
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 @Tags(['ff'])
+library;
+
 import 'package:test/test.dart';
 
 import 'package:webdriver/sync_core.dart';