Explicitly close http clients #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jan 28, 2025
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## 3.1.0-wip | |||
There was a problem hiding this comment.
If you want to change this - and the pubspec version to remove the -wip, we can publish after this lands.
There was a problem hiding this comment.
Done. Btw, looks like github actions fail both on this pr and on main branch the same way
There was a problem hiding this comment.
Gotcha; I filed #312; we need to move away from some deprecated APIs.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
mraleph
reviewed
Jan 29, 2025
| @@ -62,6 +62,7 @@ Future<WebDriver> createDriver( | |||
| final session = await client.send( | |||
There was a problem hiding this comment.
nit: this should have probably been using try {} finally {} to make sure that client is closed even if send causes an exception. Otherwise you might end up with the same 15s timeout.
Not that it matters for typical usage - but it is cleaner that way.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 5, 2025
…eb_socket_channel, webdev, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/3b35aca..2458e1a): 2458e1aa 2025-01-28 Vladimir E. Koltunov [fix,async] exception in async _CancelOnErrorSubscriptionWrapper.onError (dart-lang/core#855) ecosystem (https://github.com/dart-lang/ecosystem/compare/c4a163a..5b0d815): 5b0d815 2025-02-03 dependabot[bot] Bump the github-actions group with 6 updates (dart-lang/ecosystem#340) http (https://github.com/dart-lang/http/compare/6d99ff5..c7cc4f8): c7cc4f8 2025-01-29 Brian Quinlan [ok_http] Add support for client certificates using Java `PrivateKey`s (dart-lang/http#1444) markdown (https://github.com/dart-lang/markdown/compare/19aaded..62f78c6): 62f78c6 2025-02-01 dependabot[bot] Bump actions/stale from 9.0.0 to 9.1.0 in the github-actions group (dart-lang/markdown#635) test (https://github.com/dart-lang/test/compare/92eed6c..2ccfc5c): 2ccfc5cd 2025-02-01 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/test#2455) d8ee364a 2025-01-28 Lasse R.H. Nielsen Release fake_async v1.3.3 (dart-lang/test#2453) 385c4f75 2025-01-28 Lasse R.H. Nielsen Remove "-wip" from CHANGELOG.md too. 82417ab3 2025-01-27 Lasse R.H. Nielsen Release fake_async v1.3.3 vector_math (https://github.com/google/vector_math.dart/compare/bd4b574..533c513): 533c513 2025-02-01 dependabot[bot] Bump the github-actions group with 2 updates (google/vector_math.dart#339) web (https://github.com/dart-lang/web/compare/fd3d988..c2d5f63): c2d5f63 2025-02-01 dependabot[bot] Bump actions/stale from 9.0.0 to 9.1.0 in the github-actions group (dart-lang/web#338) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/a937243..f335e52): f335e52 2025-02-01 dependabot[bot] Bump actions/stale from 9.0.0 to 9.1.0 in the github-actions group (dart-lang/web_socket_channel#391) webdev (https://github.com/dart-lang/webdev/compare/5dc7950..616da45): 616da455 2025-01-30 Srujan Gaddam [dwds] Implement hot reload and publish 24.3.4 (dart-lang/webdev#2583) a7ea61ff 2025-01-28 Jessy Yameogo Added support for getModuleLibraries with the DDC library bundle format (dart-lang/webdev#2581) webdriver (https://github.com/google/webdriver.dart/compare/d83d6a3..e84e9cc): e84e9cc 2025-01-28 Ivan Inozemtsev Explicitly close http clients (google/webdriver.dart#311) Change-Id: I0c7fc6c3d0ae8f810c753babd9297d5f9565a0ee Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407940 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Kevin Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to speed up shutdown for ~15 seconds in certain circumstances.