-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Brotli to v0.5.2 #63
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
well, if anything, you want to checkout the submodule at the latest tagged release: |
oh, that's already the case! |
CLA re-check |
CLAs look good, thanks! |
Note that @khaledhosny has opened #61 |
I saw that but figured that it would be better to upgrade to a release commit instead of HEAD of master. |
Is Google interested in taking this PR? |
We be interested :) Thanks for the PR and sorry for the slow response. However, could I impose on you to bump brotli to the current latest release (0.5.2)? - the commit in this PR doesn't appear to match any currently listed on https://github.com/google/brotli/releases. |
This commit is actually 0.5.2. they are both tagged to the same commit ID. I can update the commit message if you like. |
Okay, I've updated the commit message to reflect the more accurate version number |
I have created a new PR for this change after adding tests and fixing build issues. I must have missed the conversion of Brotli to use a C interface instead of the C++ one it used when I converted this commit from one used for a personal project. See #65 for the new revision, which is a bit more invasive |
This upgrades Brotli to v0.5, which is the latest available branch on GitHub.