Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FromBytes::read_from_suffix return type; remove panic paths #1716

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Sep 21, 2024

FromBytes::read_from_suffix should return a SizeError, like read_from_bytes and read_from_prefix. This commit corrects this error, and also removes unreachable panic paths in all three functions.

Makes progress towards #1692

`FromBytes::read_from_suffix` should return a `SizeError`, like
`read_from_bytes` and `read_from_prefix`. This commit corrects this
error, and also removes unreachable panic paths in all three
functions.

Makes progress towards #1692
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.61%. Comparing base (42ce158) to head (2d5304d).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
- Coverage   88.98%   88.61%   -0.38%     
==========================================
  Files          16       16              
  Lines        5830     5858      +28     
==========================================
+ Hits         5188     5191       +3     
- Misses        642      667      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jswrenn jswrenn added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit c57e3b9 Sep 21, 2024
86 checks passed
@jswrenn jswrenn deleted the fix-read_from_suffix branch September 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants