Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[byteorder] Implement additional ops for native RHSs #1741

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[byteorder] Implement additional ops for native RHSs #1741

merged 1 commit into from
Sep 24, 2024

Conversation

jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Sep 23, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.32%. Comparing base (fbb0f8b) to head (609cacb).

Files with missing lines Patch % Lines
src/byteorder.rs 96.20% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
+ Coverage   88.01%   88.32%   +0.30%     
==========================================
  Files          16       16              
  Lines        5833     5962     +129     
==========================================
+ Hits         5134     5266     +132     
+ Misses        699      696       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf force-pushed the more-ops branch 2 times, most recently from e6f0ac9 to 5381ede Compare September 24, 2024 17:22
@joshlf
Copy link
Member

joshlf commented Sep 24, 2024

My plan is to not do the array impls in this PR, but follow up in #1749.

@joshlf joshlf marked this pull request as ready for review September 24, 2024 17:32
@joshlf joshlf mentioned this pull request Sep 24, 2024
87 tasks
@jswrenn
Copy link
Collaborator Author

jswrenn commented Sep 24, 2024

LGTM!

@joshlf joshlf enabled auto-merge September 24, 2024 22:30
@joshlf joshlf added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 6b7a012 Sep 24, 2024
86 checks passed
@joshlf joshlf deleted the more-ops branch September 24, 2024 22:55
@joshlf
Copy link
Member

joshlf commented Sep 27, 2024

I'm testing this to confirm that it doesn't cause inference issues for Fuchsia in https://fxrev.dev/1127272.

@joshlf
Copy link
Member

joshlf commented Sep 27, 2024

I'm testing this to confirm that it doesn't cause inference issues for Fuchsia in https://fxrev.dev/1127272.

This has landed successfully.

@jswrenn
Copy link
Collaborator Author

jswrenn commented Sep 27, 2024

Wahoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants