-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pointer][transmute] Migrate from util #1898
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 13, 2024 17:25
5e5d01d
to
231e3e3
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 13, 2024 17:25
0b32de6
to
a2a4c7f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1898 +/- ##
=======================================
Coverage 87.66% 87.66%
=======================================
Files 17 18 +1
Lines 5967 5967
=======================================
Hits 5231 5231
Misses 736 736 ☔ View full report in Codecov by Sentry. |
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 14:58
231e3e3
to
c19a3e9
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 14:58
a2a4c7f
to
a328387
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 15:24
c19a3e9
to
148380c
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 15:24
a328387
to
73954e8
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 15:30
148380c
to
d2919d9
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 15:30
73954e8
to
5048592
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 17:14
d2919d9
to
3928ed2
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 17:14
5048592
to
12f6b94
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 17:34
3928ed2
to
47de3c7
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 17:34
12f6b94
to
0cfcccb
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 17:50
47de3c7
to
2480958
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 17:50
0cfcccb
to
9cd6c63
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 18:30
2480958
to
c3590eb
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 18:30
9cd6c63
to
6ca10d8
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 19:03
c3590eb
to
d176d7a
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 19:03
6ca10d8
to
38261ac
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 19:57
d176d7a
to
69792bc
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 19:57
38261ac
to
37d6dbb
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 20:45
69792bc
to
6bc91f5
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 20:45
37d6dbb
to
71629ea
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 20:58
6bc91f5
to
8451eff
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 20:58
71629ea
to
25299c0
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 21:35
8451eff
to
e5494fe
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 21:35
25299c0
to
caba029
Compare
joshlf
force-pushed
the
ptr-invariant-conversion-mapping
branch
from
October 14, 2024 21:47
e5494fe
to
a991c04
Compare
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 21:47
caba029
to
be76996
Compare
This prepares us to rename `TransparentWrapper` to `TransmuteFrom`, which we'll do in a follow-up commit to preserve nice git diffs. Makes progress on #1122
joshlf
force-pushed
the
ptr-transmute-from-rename
branch
from
October 14, 2024 22:58
be76996
to
e5b1f21
Compare
Obsoleted by #1911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares us to rename
TransparentWrapper
toTransmuteFrom
, which we'll do in a follow-up commit to preserve nice git diffs.Makes progress on #1122