Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pointer][transmute] Migrate from util #1898

Closed
wants to merge 1 commit into from
Closed

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 13, 2024

This prepares us to rename TransparentWrapper to TransmuteFrom, which we'll do in a follow-up commit to preserve nice git diffs.

Makes progress on #1122

@joshlf joshlf requested a review from jswrenn October 13, 2024 01:34
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 5e5d01d to 231e3e3 Compare October 13, 2024 17:25
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 0b32de6 to a2a4c7f Compare October 13, 2024 17:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 32.95455% with 59 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (0665b90) to head (e5b1f21).

Files with missing lines Patch % Lines
src/pointer/transmute.rs 39.18% 45 Missing ⚠️
src/util/macros.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1898   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files          17       18    +1     
  Lines        5967     5967           
=======================================
  Hits         5231     5231           
  Misses        736      736           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 231e3e3 to c19a3e9 Compare October 14, 2024 14:58
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from a2a4c7f to a328387 Compare October 14, 2024 14:58
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from c19a3e9 to 148380c Compare October 14, 2024 15:24
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from a328387 to 73954e8 Compare October 14, 2024 15:24
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 148380c to d2919d9 Compare October 14, 2024 15:30
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 73954e8 to 5048592 Compare October 14, 2024 15:30
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from d2919d9 to 3928ed2 Compare October 14, 2024 17:14
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 5048592 to 12f6b94 Compare October 14, 2024 17:14
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 3928ed2 to 47de3c7 Compare October 14, 2024 17:34
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 12f6b94 to 0cfcccb Compare October 14, 2024 17:34
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 47de3c7 to 2480958 Compare October 14, 2024 17:50
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 0cfcccb to 9cd6c63 Compare October 14, 2024 17:50
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 2480958 to c3590eb Compare October 14, 2024 18:30
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 9cd6c63 to 6ca10d8 Compare October 14, 2024 18:30
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from c3590eb to d176d7a Compare October 14, 2024 19:03
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 6ca10d8 to 38261ac Compare October 14, 2024 19:03
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from d176d7a to 69792bc Compare October 14, 2024 19:57
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 38261ac to 37d6dbb Compare October 14, 2024 19:57
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 69792bc to 6bc91f5 Compare October 14, 2024 20:45
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 37d6dbb to 71629ea Compare October 14, 2024 20:45
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 6bc91f5 to 8451eff Compare October 14, 2024 20:58
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 71629ea to 25299c0 Compare October 14, 2024 20:58
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 8451eff to e5494fe Compare October 14, 2024 21:35
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from 25299c0 to caba029 Compare October 14, 2024 21:35
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from e5494fe to a991c04 Compare October 14, 2024 21:47
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from caba029 to be76996 Compare October 14, 2024 21:47
Base automatically changed from ptr-invariant-conversion-mapping to main October 14, 2024 22:18
This prepares us to rename `TransparentWrapper` to `TransmuteFrom`,
which we'll do in a follow-up commit to preserve nice git diffs.

Makes progress on #1122
@joshlf joshlf force-pushed the ptr-transmute-from-rename branch from be76996 to e5b1f21 Compare October 14, 2024 22:58
@joshlf
Copy link
Member Author

joshlf commented Oct 15, 2024

Obsoleted by #1911

@joshlf joshlf closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants