Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster #101

Merged
merged 2 commits into from
Jun 13, 2024
Merged

faster #101

merged 2 commits into from
Jun 13, 2024

Conversation

jyrkialakuijala
Copy link
Collaborator

~3 % altogether, perhaps 30 % for this function

Before:

|Score type |MSE               |Min score         |Max score         |Mean score        |
|-----------|------------------|------------------|------------------|------------------|
|Zimtohrli  |0.101641872045228 |0.563959418943879 |0.762245848804069 |0.686398636984063 |
|ViSQOL     |0.115330916105424 |0.520833375452983 |0.801480831107469 |0.675101633981268 |
|2f         |0.129541391104905 |0.484687555319526 |0.797475783883375 |0.661870345773127 |
|PESQ       |0.147425552045669 |0.342342966279351 |0.841271127756762 |0.647128996775172 |
|CDPAM      |0.153471222942756 |0.441558428344727 |0.728779141125759 |0.620699318941738 |
|PARLAQ     |0.185057687192323 |0.445261140223642 |0.784370761057963 |0.587162756572532 |
|AQUA       |0.223207996944378 |0.331645933512413 |0.739286336419790 |0.547804951221731 |
|PEAQB      |0.225217321572038 |0.278744167467764 |0.851011116004117 |0.553935720513487 |
|DPAM       |0.315810440183130 |0.186717781679534 |0.690564701717118 |0.460415212267967 |
|WARP-Q     |0.339686211572685 |0.067600137543649 |0.777119464646524 |0.475793617709890 |
|GVPMOS     |0.412937133868407 |0.006851162794410 |0.783946603687895 |0.412912222208318 |

real	44m52.908s # not indicative as the terminal was blocked by
another window and consequently blocking the computation on my desktop

user	748m34.686s
sys	219m0.831s

After:

|Score type |MSE               |Min score         |Max score         |Mean score        |
|-----------|------------------|------------------|------------------|------------------|
|Zimtohrli  |0.101642192840456 |0.563959418943879 |0.762245848804069 |0.686398039616168 |
|ViSQOL     |0.115330916105424 |0.520833375452983 |0.801480831107469 |0.675101633981268 |
|2f         |0.129541391104905 |0.484687555319526 |0.797475783883375 |0.661870345773127 |
|PESQ       |0.147425552045669 |0.342342966279351 |0.841271127756762 |0.647128996775172 |
|CDPAM      |0.153471222942756 |0.441558428344727 |0.728779141125759 |0.620699318941738 |
|PARLAQ     |0.185057687192323 |0.445261140223642 |0.784370761057963 |0.587162756572532 |
|AQUA       |0.223207996944378 |0.331645933512413 |0.739286336419790 |0.547804951221731 |
|PEAQB      |0.225217321572038 |0.278744167467764 |0.851011116004117 |0.553935720513487 |
|DPAM       |0.315810440183130 |0.186717781679534 |0.690564701717118 |0.460415212267967 |
|WARP-Q     |0.339686211572685 |0.067600137543649 |0.777119464646524 |0.475793617709890 |
|GVPMOS     |0.412937133868407 |0.006851162794410 |0.783946603687895 |0.412912222208318 |

real	13m52.362s
user	625m20.070s
sys	279m59.803s

17 % reduction in user time

some more speedup on the gammatone filter side
Before:

Score type	MSE	Min score	Max score	Mean score
Zimtohrli	0.101642192840456	0.563959418943879	0.762245848804069	0.686398039616168
ViSQOL	0.115330916105424	0.520833375452983	0.801480831107469	0.675101633981268
2f	0.129541391104905	0.484687555319526	0.797475783883375	0.661870345773127
PESQ	0.147425552045669	0.342342966279351	0.841271127756762	0.647128996775172
CDPAM	0.153471222942756	0.441558428344727	0.728779141125759	0.620699318941738
PARLAQ	0.185057687192323	0.445261140223642	0.784370761057963	0.587162756572532
AQUA	0.223207996944378	0.331645933512413	0.739286336419790	0.547804951221731
PEAQB	0.225217321572038	0.278744167467764	0.851011116004117	0.553935720513487
DPAM	0.315810440183130	0.186717781679534	0.690564701717118	0.460415212267967
WARP-Q	0.339686211572685	0.067600137543649	0.777119464646524	0.475793617709890
GVPMOS	0.412937133868407	0.006851162794410	0.783946603687895	0.412912222208318
real 13m52.362s
user 625m20.070s
sys 279m59.803s

After:

|Score type |MSE               |Min score         |Max score         |Mean score        |
|-----------|------------------|------------------|------------------|------------------|
|Zimtohrli  |0.101642192138072 |0.563959418943879 |0.762245848804069 |0.686398040909622 |
|ViSQOL     |0.115330916105424 |0.520833375452983 |0.801480831107469 |0.675101633981268 |
|2f         |0.129541391104905 |0.484687555319526 |0.797475783883375 |0.661870345773127 |
|PESQ       |0.147425552045669 |0.342342966279351 |0.841271127756762 |0.647128996775172 |
|CDPAM      |0.153471222942756 |0.441558428344727 |0.728779141125759 |0.620699318941738 |
|PARLAQ     |0.185057687192323 |0.445261140223642 |0.784370761057963 |0.587162756572532 |
|AQUA       |0.223207996944378 |0.331645933512413 |0.739286336419790 |0.547804951221731 |
|PEAQB      |0.225217321572038 |0.278744167467764 |0.851011116004117 |0.553935720513487 |
|DPAM       |0.315810440183130 |0.186717781679534 |0.690564701717118 |0.460415212267967 |
|WARP-Q     |0.339686211572685 |0.067600137543649 |0.777119464646524 |0.475793617709890 |
|GVPMOS     |0.412937133868407 |0.006851162794410 |0.783946603687895 |0.412912222208318 |

real	13m46.277s
user	611m8.295s
sys	281m14.419s

a few percent more speedup on user time
@zond zond merged commit 8ca90f6 into google:main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants