Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter low quality distortions #134

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Filter low quality distortions #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d3a4d3
Added option to filter out low quality distortions when sampling one …
Jan 22, 2025
54a0bce
Made the MOS filtering use a common scale for the MOS scores.
Jan 22, 2025
58017b3
Added option to filter out low quality distortions when sampling one …
Jan 22, 2025
0c9bcaf
..
Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions go/bin/score/score.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,15 @@ func main() {
if err != nil {
log.Fatal(err)
}
scaler, err := bundle.MOSScaler()
if err != nil {
log.Fatal(err)
}
func() {
defer dest.Close()
if *sampleFraction == 1.0 {
bar := progress.New(fmt.Sprintf("Copying %q", filepath.Base(bundle.Dir)))
if err := dest.Copy(bundle.Dir, bundle.References, *sampleMinMOS, bar.Update); err != nil {
if err := dest.Copy(bundle.Dir, bundle.References, *sampleMinMOS, scaler, bar.Update); err != nil {
log.Fatal(err)
}
bar.Finish()
Expand All @@ -108,14 +112,14 @@ func main() {
bar := progress.New(fmt.Sprintf("Copying %v of %q", *sampleFraction, filepath.Base(bundle.Dir)))
for _, index := range rng.Perm(numRefs) {
ref := bundle.References[index]
if ref.HasMOSAbove(*sampleMinMOS) {
if ref.HasMOSAbove(*sampleMinMOS, scaler) {
toCopy = append(toCopy, bundle.References[index])
}
if len(toCopy) >= numWanted {
break
}
}
if err := dest.Copy(bundle.Dir, toCopy, *sampleMinMOS, bar.Update); err != nil {
if err := dest.Copy(bundle.Dir, toCopy, *sampleMinMOS, scaler, bar.Update); err != nil {
log.Fatal(err)
}
bar.Finish()
Expand Down
25 changes: 17 additions & 8 deletions go/data/study.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ func (r *ReferenceBundle) IsJND() bool {
return res
}

// ScaledMOS returns the MOS score scaled to 1-5.
func (r *ReferenceBundle) ScaledMOS(mos float64) (float64, error) {
// MOSScaler returns a function that scales MOS scores of this bundle to the range 1-5.
func (r *ReferenceBundle) MOSScaler() (func(float64) float64, error) {
if r.mosScaler == nil {
if math.Abs(*r.ScoreTypeLimits[MOS][0]-1) < 0.2 && math.Abs(*r.ScoreTypeLimits[MOS][1]-5) < 0.2 {
r.mosScaler = func(mos float64) float64 {
Expand All @@ -129,10 +129,19 @@ func (r *ReferenceBundle) ScaledMOS(mos float64) (float64, error) {
return 1 + 0.04*mos
}
} else {
return 0, fmt.Errorf("minimum MOS %v and maximum MOS %v are confusing", *r.ScoreTypeLimits[MOS][0], *r.ScoreTypeLimits[MOS][1])
return nil, fmt.Errorf("minimum MOS %v and maximum MOS %v are confusing", *r.ScoreTypeLimits[MOS][0], *r.ScoreTypeLimits[MOS][1])
}
}
return r.mosScaler(mos), nil
return r.mosScaler, nil
}

// ScaledMOS returns the MOS score scaled to 1-5.
func (r *ReferenceBundle) ScaledMOS(mos float64) (float64, error) {
scaler, err := r.MOSScaler()
if err != nil {
return 0, err
}
return scaler(mos), nil
}

// SortedTypes returns the score types of a bundle, alphabetically ordered.
Expand Down Expand Up @@ -1075,7 +1084,7 @@ func (s *Study) ViewEachReference(f func(*Reference) error) error {
}

// Copy inserts some reference into a study, and copies the audio files of the references and their distortions, assuming they are relative to the provided directory.
func (s *Study) Copy(dir string, refs []*Reference, minMOS float64, progress func(int, int, int)) error {
func (s *Study) Copy(dir string, refs []*Reference, minMOS float64, mosScaler func(float64) float64, progress func(int, int, int)) error {
for index, ref := range refs {
refCopy := &Reference{}
*refCopy = *ref
Expand All @@ -1086,7 +1095,7 @@ func (s *Study) Copy(dir string, refs []*Reference, minMOS float64, progress fun
}
for index, dist := range ref.Distortions {
distCopy := &Distortion{}
if distCopy.Scores[MOS] >= minMOS {
if mosScaler == nil || mosScaler(distCopy.Scores[MOS]) >= minMOS {
*distCopy = *dist
newDistPath := fmt.Sprintf("%v_%v", filepath.Base(dir), filepath.Base(dist.Path))
distCopy.Path = newDistPath
Expand Down Expand Up @@ -1151,9 +1160,9 @@ type Reference struct {
Distortions []*Distortion
}

func (r *Reference) HasMOSAbove(min float64) bool {
func (r *Reference) HasMOSAbove(min float64, scaler func(float64) float64) bool {
for _, dist := range r.Distortions {
if dist.Scores[MOS] >= min {
if scaler(dist.Scores[MOS]) >= min {
return true
}
}
Expand Down
Loading