Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty function use in DfpSoapClient.php compatible only with PHP >= 5.5 #49

Closed
Hyunk3l opened this issue Jun 18, 2014 · 3 comments
Closed

empty function use in DfpSoapClient.php compatible only with PHP >= 5.5 #49

Hyunk3l opened this issue Jun 18, 2014 · 3 comments
Assignees
@vtsao
Labels
bug
Milestone
5.3.1

Comments

@Hyunk3l
Copy link

Hyunk3l commented Jun 18, 2014

Hi,

in this file https://github.com/googleads/googleads-php-lib/blob/master/src/Google/Api/Ads/Dfp/Lib/DfpSoapClient.php at line 67, there is a function call (empty) compatible only with PHP versions >= 5.5.
Taking a look at PHP empty function doc page:

Prior to PHP 5.5, empty() only supports variables; anything else will result in a parse error. In other words, the following will not work: empty(trim($name)). Instead, use trim($name) == false.

Can you change it please?

Regards
thackerja added a commit to thackerja/googleads-php-lib that referenced this issue Jun 23, 2014
@thackerja
Update DfpSoapClient.php
5e942b4 
Edit to lines 66 and 68; Fix for issue googleads#49
googleads#49
@Hyunk3l
Copy link
Author

Hyunk3l commented Jun 27, 2014

Nice one 👍

@vtsao vtsao self-assigned this Jun 27, 2014
@vtsao
Copy link
Contributor

vtsao commented Jun 27, 2014

We'll fix this soon, thanks for reporting.

@tharangakothalawala tharangakothalawala mentioned this issue Jun 29, 2014
Closed
@saturnism saturnism added this to the 5.3.1 milestone Jul 2, 2014
@saturnism saturnism added the bug label Jul 8, 2014
@saturnism
Copy link
Contributor

This should be fixed in the 5.3.1 release. Cheers.

@amnartb amnartb mentioned this issue Jan 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtsao vtsao

Labels
bug
Projects
None yet
Milestone
5.3.1
Development

No branches or pull requests
3 participants
@vtsao @Hyunk3l @saturnism