fix(wrapper): Resets contentComplete correctly #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that would prevent the nopostroll event from being triggered, causing a delay before contrib-ads would fire the ended event on the player Fixes googleads#639
|
@shawnbuso @ypavlotsky No idea why the tests are failing here. Ran locally and everything's working fine, I'm assuming there's just a timeout issue on the CI. Let me know if there's any additional concerns. I was also wondering if it'd be possible to get this out as a new patch version on NPM once merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that would prevent the
nopostrollevent from being triggered, causing a delay beforecontrib-adswould fire theendedevent on the playerFixes #639