Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize "early" REGAPIC failures #623

Closed
jskeet opened this issue Oct 14, 2022 · 0 comments · Fixed by #633 or #664
Closed

Standardize "early" REGAPIC failures #623

jskeet opened this issue Oct 14, 2022 · 0 comments · Fixed by #633 or #664
Assignees
@jskeet
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jskeet
Copy link
Collaborator

jskeet commented Oct 14, 2022

If we try to call a method that we don't know how to execute in RestGrpcAdapter (e.g. due to an unsupported streaming mode, or a lack of HTTP configuration) we should throw an RpcException with a NotImplemented status code and an informative message.
@jskeet jskeet added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 14, 2022
@jskeet jskeet self-assigned this Oct 14, 2022
jskeet added a commit to jskeet/gax-dotnet that referenced this issue Nov 25, 2022
@jskeet
feat: Improve handling of bad/missing/unsupported methods in REGAPIC
291c021 
- If a method is improperly configured, that should fail when trying to construct the client. (We can then have simple unit tests for that.)
- If a method is generally okay, but unsupported by REGAPIC, that should fail when called, with an informative RpcException
- If a method doesn't exist, that should fail when called, with an informative RpcException. (This shouldn't really happen - it would be a bug.)

Fixes googleapis#623
jskeet added a commit to jskeet/gax-dotnet that referenced this issue Nov 25, 2022
@jskeet
feat: Improve handling of bad/missing/unsupported methods in REGAPIC
bf9865f 
- If a method is improperly configured, that should fail when trying to construct the client. (We can then have simple unit tests for that.)
- If a method is generally okay, but unsupported by REGAPIC, that should fail when called, with an informative RpcException
- If a method doesn't exist, that should fail when called, with an informative RpcException. (This shouldn't really happen - it would be a bug.)

Fixes googleapis#623
@jskeet jskeet closed this as completed in 703f386 Nov 25, 2022
@release-please release-please bot mentioned this issue Nov 25, 2022
Merged
@jskeet jskeet mentioned this issue Dec 8, 2022
Merged
@release-please release-please bot mentioned this issue Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
1 participant
@jskeet