fix: better error handling for REST transport #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
reviewed
Mar 9, 2023
sofisl
approved these changes
Mar 9, 2023
danieljbruce
reviewed
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1423.
In REST streaming use case,
callbackis not provided. Instead, the caller expects to seeerrorevents in the returned stream. If, for whatever reason, an error occurs in the streaming call, the caller would getTypeError: callback is not a function.Make sure we only call
callbackif it's provided, and use the stream emitter to report errors in other cases.Note: the unrelated change to
mkdirpimport is just because they are apparently making ESM related changes. It just makes our code compile again.