feat: add ESM tools in gax #1459
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // Copyright 2023 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import {Visitor, types} from '@babel/core'; | ||
|
|
||
| export interface PluginOptions { | ||
| opts?: { | ||
| fromLibName?: string; | ||
| toLibName?: string; | ||
| }; | ||
| } | ||
|
|
||
| export default function replaceESMMockingLib(): { | ||
| visitor: Visitor<PluginOptions>; | ||
| } { | ||
| return { | ||
| visitor: { | ||
| ImportDeclaration(path, state) { | ||
| const opts = state.opts || {}; | ||
| const fromLib = opts.fromLibName || 'esmock'; | ||
| const toLib = opts.toLibName || 'proxyquire'; | ||
| const {node} = path; | ||
|
|
||
| node.specifiers.forEach(spec => { | ||
| if (spec.local.name !== fromLib) { | ||
| return; | ||
| } | ||
| spec.local.name = spec.local.name.replace(fromLib, toLib); | ||
| }); | ||
|
|
||
| if (node.source.value !== fromLib) { | ||
| return; | ||
| } | ||
| node.source.value = node.source.value.replace(fromLib, toLib); | ||
| }, | ||
| CallExpression(path, state) { | ||
| const opts = state.opts || {}; | ||
| const fromLib = opts.fromLibName || 'esmock'; | ||
| const toLib = opts.toLibName || 'proxyquire'; | ||
| const {node} = path; | ||
|
|
||
| if (types.isIdentifier(node.callee)) { | ||
| if (node.callee.name !== fromLib) { | ||
| return; | ||
| } | ||
|
|
||
| node.callee.name = toLib; | ||
| path.parentPath.replaceWith(types.expressionStatement(node)); | ||
| } | ||
| }, | ||
| }, | ||
| }; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Copyright 2023 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // eslint-disable-next-line node/no-extraneous-import | ||
| import {smart} from '@babel/template'; | ||
| import {Statement} from '@babel/types'; | ||
| import {Visitor} from '@babel/core'; | ||
|
|
||
| export interface PluginOptions { | ||
| opts?: { | ||
| replacementValue?: string; | ||
| }; | ||
| } | ||
|
|
||
| export default function replaceImportMetaUrl(): { | ||
| visitor: Visitor<PluginOptions>; | ||
| } { | ||
| return { | ||
| visitor: { | ||
| CallExpression(path, state) { | ||
| const opts = state.opts || {}; | ||
| const replacementValue = opts.replacementValue || '__dirname'; | ||
| const {node} = path; | ||
| if ( | ||
| node.callee.type === 'MemberExpression' && | ||
| node.callee.object.type === 'Identifier' && | ||
| node.callee.object.name === 'path' && | ||
|
There was a problem hiding this comment. @sofisl can we remove the There was a problem hiding this comment. Ignore the above. However, for this to not get mangled I had to do There was a problem hiding this comment. @ddelgrosso1, we could remove lines 37 and 38, and still preserve matching (tests still behave the same). Should we do that, that way it's not so fragile? |
||
| node.callee.property.type === 'Identifier' && | ||
| node.callee.property.name === 'dirname' && | ||
| node.arguments[0].type === 'CallExpression' && | ||
| node.arguments[0].callee.type === 'Identifier' && | ||
| node.arguments[0].callee.name === 'fileURLToPath' && | ||
| node.arguments[0].arguments[0].type === 'MemberExpression' && | ||
| node.arguments[0].arguments[0].object.type === 'MetaProperty' && | ||
| node.arguments[0].arguments[0].object.meta.type === 'Identifier' && | ||
| node.arguments[0].arguments[0].object.meta.name === 'import' && | ||
| node.arguments[0].arguments[0].object.property.type === | ||
| 'Identifier' && | ||
| node.arguments[0].arguments[0].object.property.name === 'meta' && | ||
| node.arguments[0].arguments[0].property.type === 'Identifier' && | ||
| node.arguments[0].arguments[0].property.name === 'url' | ||
| ) { | ||
| const replacement = smart.ast`${replacementValue}` as Statement; | ||
| path.replaceWith(replacement); | ||
| } | ||
| }, | ||
| }, | ||
| }; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Copyright 2023 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import {Visitor, types} from '@babel/core'; | ||
|
|
||
| export interface PluginOptions { | ||
| opts?: { | ||
| variableIdentifier?: string; | ||
| replacementValue?: boolean; | ||
| }; | ||
| } | ||
|
|
||
| export default function toggleESMFlagVariable(): { | ||
| visitor: Visitor<PluginOptions>; | ||
| } { | ||
| return { | ||
| visitor: { | ||
| VariableDeclarator(path, state) { | ||
| const opts = state.opts || {}; | ||
| const variableIdentifier = opts.variableIdentifier || 'isEsm'; | ||
| const replacementValue = opts.replacementValue || false; | ||
| const {node} = path; | ||
| const identifier = node.id as types.Identifier; | ||
| if ( | ||
| identifier.name === variableIdentifier && | ||
| node.init?.type === 'BooleanLiteral' | ||
| ) { | ||
| node.init.value = replacementValue; | ||
| } | ||
| }, | ||
| }, | ||
| }; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit but let's either make this "0." or increment the numbers below :)