chore(deps): Bump gaxios
#649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-goog
commented
Feb 7, 2025
| @@ -47,7 +46,7 @@ export const METADATA_SERVER_DETECTION = Object.freeze({ | |||
| export interface Options { | |||
| params?: {[index: string]: string}; | |||
| property?: string; | |||
| headers?: OutgoingHttpHeaders; | |||
| headers?: HeadersInit; | |||
There was a problem hiding this comment.
HeadersInit is a broader, spec-compliant type when compared to OutgoingHttpHeaders.
d-goog
commented
Feb 7, 2025
|
|
||
| if (typeof type === 'object') { | ||
| const metadataAccessor: MetadataAccessor = type; | ||
|
|
||
| new Headers(metadataAccessor.headers).forEach((value, key) => |
There was a problem hiding this comment.
Merging headers; matching existing behavior (as seen on line 159 on the current state).
|
Note: system test failures exist outside from this PR: Investigating... |
sofisl
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
gaxiosto its release candidate.🦕