Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

chore(dep): deprecate Node 8 #330

Merged
merged 2 commits into from
Apr 1, 2020
Merged

chore(dep): deprecate Node 8 #330

merged 2 commits into from
Apr 1, 2020

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Apr 1, 2020

deprecate Node 8

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@summer-ji-eng summer-ji-eng requested a review from bcoe April 1, 2020 05:36
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #330 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #330     +/-   ##
=========================================
- Coverage   93.54%   93.25%   -0.3%     
=========================================
  Files           2        2             
  Lines         682      682             
  Branches       96       83     -13     
=========================================
- Hits          638      636      -2     
  Misses         44       44             
- Partials        0        2      +2
Impacted Files Coverage Δ
src/index.ts 98.14% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e26a89...93355e7. Read the comment docs.

@summer-ji-eng summer-ji-eng merged commit ab87586 into master Apr 1, 2020
@summer-ji-eng summer-ji-eng deleted the summer_dep_node branch April 1, 2020 17:05
@summer-ji-eng summer-ji-eng restored the summer_dep_node branch April 1, 2020 18:56
summer-ji-eng added a commit that referenced this pull request Apr 1, 2020
summer-ji-eng added a commit that referenced this pull request Apr 1, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 1, 2020
Deprecate node 8 is breaking change.
Fix the commit message #330
@release-please release-please bot mentioned this pull request Apr 1, 2020
@summer-ji-eng summer-ji-eng deleted the summer_dep_node branch April 1, 2020 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants