Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate based on discovery-artifact-manager #2682

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jul 10, 2024

Most other languages do not pull discovery documents directly from the discovery service, instead they share a cache. This change makes Go use that same cache while also maintaining the cached files in this repo.

Other changes:

  • Added a dryrun flag to discogen for local testing
  • downgraded discogen deps to work with Go 1.20
  • return no doc error if the file in the index is not cached locally. This operates the same as when we pulled from the disco service, where if we got a non-2XX we would silently skip generating an api

Internal bug: 352084622

@codyoss codyoss requested a review from a team as a code owner July 10, 2024 22:06
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jul 10, 2024
424e1fa
Most other languages do not pull discovery documents directly from
the discovery service, instead they share a cache. This change
makes Go use that same cache while also maintaining the cached
files in this repo.

Other changes:
- Added a dryrun flag to discogen for local testing
- downgraded discogen deps to work with Go 1.20
- return no doc error if the file in the index is not cached
  locally. This operates the same as when we pulled from the disco
  service, where if we got a non-2XX we would silently skip
  generating an api

Internal bug: 352084622
@googleapis googleapis deleted a comment from google-cla bot Jul 10, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit eba243a into googleapis:main Jul 10, 2024
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 10, 2024
@codyoss codyoss deleted the regen-art branch July 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants