Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: better documentation for caching #563

Merged
merged 3 commits into from
Jun 26, 2024
Merged

docs: better documentation for caching #563

merged 3 commits into from
Jun 26, 2024

Conversation

Hectorhammett
Copy link
Contributor

closes: #562

@Hectorhammett Hectorhammett requested a review from bshaffer June 10, 2024 20:30
@Hectorhammett Hectorhammett changed the title Add documentation for caching on our current implementation Chore: Add documentation for caching on our current implementation Jun 10, 2024
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest also adding an example of implementing a third party cache, for this example. Something like

Integrating with a third party cache

To increase performance, you can use a third party file cache (such as Symfony file cache).... (show example)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Hectorhammett Hectorhammett requested a review from bshaffer June 12, 2024 19:20
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Some typos and then this is good to go

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Hectorhammett Hectorhammett marked this pull request as ready for review June 14, 2024 18:14
@Hectorhammett Hectorhammett requested a review from a team as a code owner June 14, 2024 18:14
@bshaffer bshaffer changed the title Chore: Add documentation for caching on our current implementation docs: better documentation for caching Jun 18, 2024
@bshaffer bshaffer requested a review from westarle June 19, 2024 18:56
@bshaffer bshaffer merged commit 9ebf46e into main Jun 26, 2024
11 checks passed
@bshaffer bshaffer deleted the document-caching branch June 26, 2024 19:41
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Documentation on how to enable caching.
3 participants