chore(deps): update dependency rsa to <4.7 - autoclosed #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusted-contributions-gcf
bot
added
the
kokoro:run
googlebot
added
the
cla: yes
yoshi-kokoro
removed
the
kokoro:run
tvalentyn
reviewed
Jun 15, 2020
| @@ -22,7 +22,7 @@ | |||
| "cachetools>=2.0.0,<5.0", | |||
| "pyasn1-modules>=0.2.1", | |||
| # rsa >= 4.1 no longer supports python 2 https://github.com/sybrenstuvel/python-rsa/issues/152 | |||
| 'rsa<4.1; python_version < "3"', | |||
There was a problem hiding this comment.
Thank you! I'd suggest:
- check that rsa 4.5 does not cause a breakage on Py2
- set this to '<4.6', since 4.5 should be the final version supporting Py2 as per python-rsa 4.1 dropped Python 2 support but did not add a
python_requires>=3stanza in setup.py sybrenstuvel/python-rsa#152 (comment) - Update the comment in line 24.
4 tasks
busunkim96
added
the
do not merge
renovate-bot
changed the title
trusted-contributions-gcf
bot
added
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
<4.1-><4.7Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.