This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Add CMake files and a CI build using them. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
These files allow us to build the spanner client using CMake, which we need to support `make install` and package maintainers. We can also use these to create code coverage builds, builds that run clang-tidy, and builds generate the Doxygen documentation, all of which could be done with Bazel, but would require rediscovering how to do it. These files make no attempt at installing the dependencies for the project. They assume these dependencies are installed and the build fails if they are not. The CI build pre-installs these dependencies, a future CI build will also test support for super builds. Provide instructions for developers that want to use CMake with `vcpkg` or by installing the dependencies in `/usr/local`.
I removed the instructions to install in /usr/local because they are complicated and will not live for long, the next PR will describe how to install in $HOME/local (or a similar user-owned directory). Also merged with the latest changes on `master`.
|
PTAL. |
devjgm
approved these changes
Jun 4, 2019
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…pp-spanner#39) These files allow us to build the spanner client using CMake, which we need to support `make install` and package maintainers. We can also use these to create code coverage builds, builds that run clang-tidy, and builds generate the Doxygen documentation, all of which could be done with Bazel, but would require rediscovering how to do it. These files make no attempt at installing the dependencies for the project. They assume these dependencies are installed and the build fails if they are not. The CI build pre-installs these dependencies, a future CI build will also test support for super builds. Provide instructions for developers that want to use CMake with `vcpkg`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files allow us to build the spanner client using CMake, which we
need to support
make installand package maintainers. We can also usethese to create code coverage builds, builds that run clang-tidy, and
builds generate the Doxygen documentation, all of which could be done
with Bazel, but would require rediscovering how to do it.
These files make no attempt at installing the dependencies for the
project. They assume these dependencies are installed and the build
fails if they are not. The CI build pre-installs these dependencies, a
future CI build will also test support for super builds.
Provide instructions for developers that want to use CMake with
vcpkgor by installing the dependencies in
/usr/local.This change is