cleanup(pubsub): don't link invalid messages #13649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alevenberg
changed the title
alevenberg
approved these changes
Feb 23, 2024
alevenberg
reviewed
Feb 23, 2024
| auto context = ExtractTraceContext(message, *propagator); | ||
| auto producer_span_context = | ||
| opentelemetry::trace::GetSpan(context)->GetContext(); | ||
| if (producer_span_context.IsSampled() && producer_span_context.IsValid()) { | ||
| // If the contexts are equal, the message span was invalid. |
There was a problem hiding this comment.
Note to self:
I don't think the producer_span_context.IsValid() line checks anything, that's what the check darren is adding will now check.
If the current context is equal to the extracted context, it means that the context was not valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #13627
The propagator used for messages is a no-op if the incoming span is invalid:
https://github.com/open-telemetry/opentelemetry-cpp/blob/4eb99f9e05f45c0ea1461858417e7e52135874c5/api/include/opentelemetry/trace/propagation/http_trace_context.h#L45-L48
In this case, our message receiver does not add a new context to the stack:
https://github.com/open-telemetry/opentelemetry-cpp/blob/4eb99f9e05f45c0ea1461858417e7e52135874c5/api/include/opentelemetry/trace/propagation/http_trace_context.h#L63
The latest update to opentelemetry-cpp copies trace flags from the current context:
https://github.com/open-telemetry/opentelemetry-cpp/blob/423ecacdf62196731d888621e0dfa2e8cc023b4a/sdk/src/trace/tracer.cc#L64
So we should check that the contexts are not equal.
This change is