fix: support for static builds with MSVC #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous cleanup was incorrect. CMake protects usage of CMAKE_MSVC_RUNTIME_LIBRARY with a policy, the variable (or rather the MSVC_RUNTIME_LIBRARY property set by this variable) has no effect if the CMP0091 policy is set to OLD, as would be in our builds because we say that version 3.5 is the behavior we want in cmake_minimum_required().
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5856 +/- ##
==========================================
- Coverage 95.45% 95.45% -0.01%
==========================================
Files 1115 1115
Lines 102635 102635
==========================================
- Hits 97972 97970 -2
- Misses 4663 4665 +2
Continue to review full report at Codecov.
|
devjgm
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous cleanup was incorrect. CMake protects usage of
CMAKE_MSVC_RUNTIME_LIBRARY with a policy, the variable (or rather the
MSVC_RUNTIME_LIBRARY property set by this variable) has no effect if the
CMP0091 policy is set to OLD, as would be in our builds because we say
that version 3.5 is the behavior we want in cmake_minimum_required().
This change is