Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): support bucket restore in soft delete phase 2 #13894

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(storage): support bucket restore in soft delete phase 2 #13894

wants to merge 7 commits into from

Conversation

mahendra-google
Copy link

Feature request includes the following:-

  1. Get Bucket Generation
  2. Get a Soft Deleted Bucket (Also soft-delete time and hard-delete time)
  3. List Soft Deleted Buckets
  4. Restore a Soft Deleted Bucket

@mahendra-google mahendra-google requested review from a team as code owners November 28, 2024 12:39
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 28, 2024
jskeet
jskeet reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a full code review by any means, but I'm hoping that this little bit will reduce the number of iterations required after Amanda is back from Thanksgiving.

Directory.Packages.props Outdated Show resolved Hide resolved
@mahendra-google
Copy link
Author

This is not a full code review by any means, but I'm hoping that this little bit will reduce the number of iterations required after Amanda is back from Thanksgiving.

Ok

@jskeet
Copy link
Collaborator

jskeet commented Nov 29, 2024

Unassigning myself from review - I'm on vacation until Tuesday. (I expect Amanda will review before then.)

@amanda-tarafa amanda-tarafa self-assigned this Dec 3, 2024
@amanda-tarafa
Copy link
Contributor

I'll review today. @mahendra-google if you can rebase on main to remove conflicts, that'd be great, thanks.

@mahendra-google
Copy link
Author

I'll review today. @mahendra-google if you can rebase on main to remove conflicts, that'd be great, thanks.

@amanda-tarafa I have removed conflict for Directory.Packages.props file.

@mahendra-google
Copy link
Author

I'll review today. @mahendra-google if you can rebase on main to remove conflicts, that'd be great, thanks.

@amanda-tarafa I have removed conflict for Directory.Packages.props file.

@amanda-tarafa I have removed project file conflict.

@mahendra-google
Copy link
Author

mahendra-google commented Dec 6, 2024 •
edited
Loading

@amanda-tarafa Storage Samples requires latest package of Google.Cloud.Storage.V1 having properties of GetBucketOptions , ListBucketOptions, RestoreBucketOptions to work sample as expected. So for samples can I proceed with lastest dlls?

amanda-tarafa
amanda-tarafa requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add unit tests for all the option classes that you modified. See #12060 for examples.

apis/apis.json Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.csproj Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClientImpl.RestoreBucket.cs Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClientImpl.RestoreBucket.cs Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClientImpl.RestoreBucket.cs Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/ListBucketsTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
amanda-tarafa
amanda-tarafa requested changes Jan 8, 2025
View reviewed changes
apis/apis.json Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.csproj Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClientImpl.RestoreBucket.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClientImpl.RestoreBucket.cs Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/RestoreBucketOptions.cs Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/GetBucketTest.cs Outdated Show resolved Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.Tests/RestoreBucketOptionsTest.cs Outdated Show resolved Hide resolved
@mahendra-google mahendra-google force-pushed the restore_bucket_soft_delete_phase_2 branch from cb1650a to db71efc Compare January 28, 2025 06:01
@mahendra-google
Copy link
Author

You need to add unit tests for all the option classes that you modified. See #12060 for examples.

Unit tests for all the option classes are added that I have modified

@mahendra-google mahendra-google force-pushed the restore_bucket_soft_delete_phase_2 branch from 0957b16 to 7efe472 Compare January 29, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-tarafa amanda-tarafa Awaiting requested review from amanda-tarafa

@jskeet jskeet Awaiting requested review from jskeet

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Requested changes must be addressed to merge this pull request.

Assignees

@amanda-tarafa amanda-tarafa

Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahendra-google @jskeet @amanda-tarafa @JesseLovelace