Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Many APIs] add support for message transforms to Topic and Subscription #14185

Merged
merged 1 commit into from
Jan 30, 2025
Merged

feat: [Many APIs] add support for message transforms to Topic and Subscription #14185

merged 1 commit into from
Jan 30, 2025

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 30, 2025

  • Regenerate this pull request now.

docs: Fix link for AnalyticsHubSubscriptionInfo

PiperOrigin-RevId: 721335502

Source-Link: googleapis/googleapis@6161270

Source-Link: https://github.com/googleapis/googleapis-gen/commit/aeb0bb9f104a35e3bd45b7fc8de8ef27987a6e58
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWVtY2FjaGUuVjFCZXRhMi8uT3dsQm90LnlhbWwiLCJoIjoiYWViMGJiOWYxMDRhMzVlM2JkNDViN2ZjOGRlOGVmMjc5ODdhNmU1OCJ9
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWVtb3J5c3RvcmUuVjEvLk93bEJvdC55YW1sIiwiaCI6ImFlYjBiYjlmMTA0YTM1ZTNiZDQ1YjdmYzhkZThlZjI3OTg3YTZlNTgifQ==
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWVtb3J5c3RvcmUuVjFCZXRhLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWV0YXN0b3JlLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWV0YXN0b3JlLlYxQWxwaGEvLk93bEJvdC55YW1sIiwiaCI6ImFlYjBiYjlmMTA0YTM1ZTNiZDQ1YjdmYzhkZThlZjI3OTg3YTZlNTgifQ==
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWV0YXN0b3JlLlYxQmV0YS8uT3dsQm90LnlhbWwiLCJoIjoiYWViMGJiOWYxMDRhMzVlM2JkNDViN2ZjOGRlOGVmMjc5ODdhNmU1OCJ9
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWlncmF0aW9uQ2VudGVyLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTmV0d29ya0Nvbm5lY3Rpdml0eS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYWViMGJiOWYxMDRhMzVlM2JkNDViN2ZjOGRlOGVmMjc5ODdhNmU1OCJ9
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTmV0d29ya1NlY3VyaXR5LlYxQmV0YTEvLk93bEJvdC55YW1sIiwiaCI6ImFlYjBiYjlmMTA0YTM1ZTNiZDQ1YjdmYzhkZThlZjI3OTg3YTZlNTgifQ==
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTmV0d29ya1NlcnZpY2VzLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuUHViU3ViLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@github-actions GitHub Actions
Copy link

Pull request diff results
OwlBot post-processor has not run: failing diff.

@gcf-owl-bot
feat: add support for message transforms to Topic and Subscription
614f815 
docs: Fix link for AnalyticsHubSubscriptionInfo

PiperOrigin-RevId: 721335502

Source-Link: googleapis/googleapis@6161270

Source-Link: googleapis/googleapis-gen@aeb0bb9
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWVtY2FjaGUuVjFCZXRhMi8uT3dsQm90LnlhbWwiLCJoIjoiYWViMGJiOWYxMDRhMzVlM2JkNDViN2ZjOGRlOGVmMjc5ODdhNmU1OCJ9
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWVtb3J5c3RvcmUuVjEvLk93bEJvdC55YW1sIiwiaCI6ImFlYjBiYjlmMTA0YTM1ZTNiZDQ1YjdmYzhkZThlZjI3OTg3YTZlNTgifQ==
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWVtb3J5c3RvcmUuVjFCZXRhLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWV0YXN0b3JlLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWV0YXN0b3JlLlYxQWxwaGEvLk93bEJvdC55YW1sIiwiaCI6ImFlYjBiYjlmMTA0YTM1ZTNiZDQ1YjdmYzhkZThlZjI3OTg3YTZlNTgifQ==
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWV0YXN0b3JlLlYxQmV0YS8uT3dsQm90LnlhbWwiLCJoIjoiYWViMGJiOWYxMDRhMzVlM2JkNDViN2ZjOGRlOGVmMjc5ODdhNmU1OCJ9
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTWlncmF0aW9uQ2VudGVyLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTmV0d29ya0Nvbm5lY3Rpdml0eS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYWViMGJiOWYxMDRhMzVlM2JkNDViN2ZjOGRlOGVmMjc5ODdhNmU1OCJ9
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTmV0d29ya1NlY3VyaXR5LlYxQmV0YTEvLk93bEJvdC55YW1sIiwiaCI6ImFlYjBiYjlmMTA0YTM1ZTNiZDQ1YjdmYzhkZThlZjI3OTg3YTZlNTgifQ==
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTmV0d29ya1NlcnZpY2VzLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuUHViU3ViLlYxLy5Pd2xCb3QueWFtbCIsImgiOiJhZWIwYmI5ZjEwNGEzNWUzYmQ0NWI3ZmM4ZGU4ZWYyNzk4N2E2ZTU4In0=
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 30, 2025 14:15
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 30, 2025 14:15
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-f76313ee67195619d0c0 branch from 6216ca5 to 614f815 Compare January 30, 2025 14:15
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@github-actions GitHub Actions
Copy link

Pull request diff results
Finding changes in Google.Cloud.PubSub.V1...
Comparing old and new versions (by source)
Minor changes:
Class 'JavaScriptUDF' added.
Class 'MessageTransform' added.
Enum 'MessageTransform.TransformOneofCase' added.
Class 'Subscription'; property 'RepeatedField MessageTransforms { get; }' added.
Class 'Subscription'; constant 'System.Int32 Google.Cloud.PubSub.V1.Subscription::MessageTransformsFieldNumber' added.
Class 'Topic'; property 'RepeatedField MessageTransforms { get; }' added.
Class 'Topic'; constant 'System.Int32 Google.Cloud.PubSub.V1.Topic::MessageTransformsFieldNumber' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.PubSub.V1 version 3.20.0
Differences from 3.20.0
Minor changes:
Class 'JavaScriptUDF' added.
Class 'MessageTransform' added.
Enum 'MessageTransform.TransformOneofCase' added.
Class 'Subscription'; property 'RepeatedField MessageTransforms { get; }' added.
Class 'Subscription'; constant 'System.Int32 Google.Cloud.PubSub.V1.Subscription::MessageTransformsFieldNumber' added.
Class 'Topic'; property 'RepeatedField MessageTransforms { get; }' added.
Class 'Topic'; constant 'System.Int32 Google.Cloud.PubSub.V1.Topic::MessageTransformsFieldNumber' added.

Diff level: Minor

Finished comparisons for Google.Cloud.PubSub.V1

@amanda-tarafa
Copy link
Contributor

@jskeet flagging because you din't merge this one. Not sure if you wanted to check something first.

@jskeet
Copy link
Collaborator

jskeet commented Jan 30, 2025

Whoops, no, just failure on my part. Merging now.

@jskeet jskeet merged commit 97502ea into main Jan 30, 2025
12 checks passed
@jskeet jskeet deleted the owl-bot-copy-f76313ee67195619d0c0 branch January 30, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanda-tarafa @jskeet