feat(storage): merge support for bi-directional multiple range reads (#…

…11377) * feat(storage): merge support for bi-directional multiple range reads * add license header * get object metadata for regular grpc reads * docs change * fix offset and remaining bytes calculation * fix(storage): use mutex for accessing concurrent vars * remove TestOpenAppendableWriterUnsupportedEmulated * Add back retry conformance tests to json * retry tests assume writes are conditionally idempoten --------- Co-authored-by: Daniel B <[email protected]>
googleapis · Jan 8, 2025 · b4d86a5 · b4d86a5
1 parent 238ac1c
commit b4d86a5
Show file tree

Hide file tree

Showing 29 changed files with 7,007 additions and 2,968 deletions.
diff --git a/storage/bucket_test.go b/storage/bucket_test.go
@@ -1119,11 +1119,11 @@ func TestBucketRetryer(t *testing.T) {
 					WithErrorFunc(func(err error) bool { return false }))
 			},
 			want: &retryConfig{
-				backoff: gaxBackoffFromStruct(&gax.Backoff{
+				backoff: &gax.Backoff{
 					Initial:    2 * time.Second,
 					Max:        30 * time.Second,
 					Multiplier: 3,
-				}),
+				},
 				policy:      RetryAlways,
 				maxAttempts: expectedAttempts(5),
 				shouldRetry: func(err error) bool { return false },
@@ -1138,9 +1138,9 @@ func TestBucketRetryer(t *testing.T) {
 					}))
 			},
 			want: &retryConfig{
-				backoff: gaxBackoffFromStruct(&gax.Backoff{
+				backoff: &gax.Backoff{
 					Multiplier: 3,
-				})},
+				}},
 		},
 		{
 			name: "set policy only",

diff --git a/storage/client.go b/storage/client.go
@@ -108,6 +108,8 @@ type storageClient interface {
 	ListNotifications(ctx context.Context, bucket string, opts ...storageOption) (map[string]*Notification, error)
 	CreateNotification(ctx context.Context, bucket string, n *Notification, opts ...storageOption) (*Notification, error)
 	DeleteNotification(ctx context.Context, bucket string, id string, opts ...storageOption) error
+
+	NewMultiRangeDownloader(ctx context.Context, params *newMultiRangeDownloaderParams, opts ...storageOption) (*MultiRangeDownloader, error)
 }
 
 // settings contains transport-agnostic configuration for API calls made via
@@ -261,6 +263,9 @@ type openWriterParams struct {
 	// sendCRC32C - see `Writer.SendCRC32C`.
 	// Optional.
 	sendCRC32C bool
+	// append - Write with appendable object semantics.
+	// Optional.
+	append bool
 
 	// Writer callbacks
 
@@ -278,6 +283,15 @@ type openWriterParams struct {
 	setObj func(*ObjectAttrs)
 }
 
+type newMultiRangeDownloaderParams struct {
+	bucket        string
+	conds         *Conditions
+	encryptionKey []byte
+	gen           int64
+	object        string
+	handle        *ReadHandle
+}
+
 type newRangeReaderParams struct {
 	bucket         string
 	conds          *Conditions
@@ -287,6 +301,7 @@ type newRangeReaderParams struct {
 	object         string
 	offset         int64
 	readCompressed bool // Use accept-encoding: gzip. Only works for HTTP currently.
+	handle         *ReadHandle
 }
 
 type getObjectParams struct {