Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: replace retry wrapping in tests with built-in configurability #5032

Closed
BrennaEpp opened this issue Oct 26, 2021 · 0 comments · Fixed by #6510
Closed

storage: replace retry wrapping in tests with built-in configurability #5032

BrennaEpp opened this issue Oct 26, 2021 · 0 comments · Fixed by #6510
Assignees
@BrennaEpp
Labels
api: storage Issues related to the Cloud Storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@BrennaEpp
Copy link
Contributor

Once the retry work is completed, we can replace custom manual retries with the library's retries
@BrennaEpp BrennaEpp added api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. status: blocked Resolving the issue is dependent on other work. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Oct 26, 2021
@BrennaEpp BrennaEpp self-assigned this Oct 26, 2021
@BrennaEpp BrennaEpp removed the status: blocked Resolving the issue is dependent on other work. label Jan 14, 2022
BrennaEpp added a commit to BrennaEpp/google-cloud-go that referenced this issue Aug 12, 2022
@BrennaEpp
refactor(storage): replace manual retries in tests
854014f 
Fixes googleapis#5032
@BrennaEpp BrennaEpp mentioned this issue Aug 12, 2022
Merged
BrennaEpp added a commit that referenced this issue Aug 28, 2022
@BrennaEpp
refactor(storage): replace manual retries in tests (#6510)
c220ca2 
Fixes #5032

Also adds a retry to the HMAC key test that fixes #6544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrennaEpp BrennaEpp

Labels
api: storage Issues related to the Cloud Storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(storage): replace manual retries in tests BrennaEpp/google-cloud-go
1 participant
@BrennaEpp