Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidiff flaging breaking changes it should not for us #7007

Closed
codyoss opened this issue Nov 9, 2022 · 2 comments · Fixed by #7008
Closed

apidiff flaging breaking changes it should not for us #7007

codyoss opened this issue Nov 9, 2022 · 2 comments · Fixed by #7008
Assignees
@noahdietz

Comments

@codyoss
Copy link
Member

codyoss commented Nov 9, 2022

apidiff is currently catching some breaking changes we don't want it to. Any time a new RPC is added to a client the proto stub has a method added to an interface. We should try to filter out these breaking changes if possible. See #7005 as an example.
@codyoss
Copy link
Member Author

codyoss commented Nov 9, 2022

cc @noahdietz

@codyoss codyoss mentioned this issue Nov 9, 2022
Merged
@noahdietz
Copy link
Contributor

Yep, need to include this bit (from go-genproto) since we are doing stubs here: https://github.com/googleapis/go-genproto/blob/main/.github/workflows/apidiff.yaml#L68-L69

@noahdietz noahdietz self-assigned this Nov 9, 2022
@noahdietz noahdietz mentioned this issue Nov 9, 2022
Merged
codyoss pushed a commit that referenced this issue Nov 17, 2022
@noahdietz
chore(ci): ignore interface additions for stubs (#7008)
8087047 
Stub directories are allowed to have interface additions as this is generated code.

Fixes #7007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): ignore interface additions for stubs noahdietz/google-cloud-go
2 participants
@codyoss @noahdietz