trace: docs refer to SpamFromHeader not SpanFromHeader #722
Assignees
Labels
api: cloudtrace
Issues related to the Cloud Trace API.
Comments
rakyll
changed the title
yoshi-automation
added a commit
that referenced
this issue
Jun 7, 2022
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#823 Changes: chore(shell): add http rules for LROs PiperOrigin-RevId: 453261273 Source-Link: googleapis/googleapis@f8e97f9 fix(talent)!: remove Application and Profile services and and related protos, enums, and messages PiperOrigin-RevId: 453241222 Source-Link: googleapis/googleapis@7837470 feat(functions): added support for CMEK docs: clarified wording around quota usage Clients can now specify the docker registry to use for storing function Docker images and KMS crypto keys for function source code objects. PiperOrigin-RevId: 453234231 Source-Link: googleapis/googleapis@d180952 feat(aiplatform): add monitor_window to ModelDeploymentMonitoringScheduleConfig proto in aiplatform v1/v1beta1 model_deployment_monitoring_job.proto PiperOrigin-RevId: 453226330 Source-Link: googleapis/googleapis@239db5e docs(contactcenterinsights): Updating comments PiperOrigin-RevId: 452751522 Source-Link: googleapis/googleapis@530ca55 feat(gkehub): Added support for locations and iam_policy clients PiperOrigin-RevId: 452647783 Source-Link: googleapis/googleapis@fbb5dd9 feat(spanner): add Session creator role docs: clarify transaction semantics PiperOrigin-RevId: 452634948 Source-Link: googleapis/googleapis@df51ec8 feat(compute): Update Compute Engine API to revision 20220526 (#722) Source-Link: googleapis/googleapis@950dd73
yoshi-automation
added a commit
that referenced
this issue
Jun 8, 2022
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#823 Changes: chore(shell): add http rules for LROs PiperOrigin-RevId: 453261273 Source-Link: googleapis/googleapis@f8e97f9 fix(talent)!: remove Application and Profile services and and related protos, enums, and messages PiperOrigin-RevId: 453241222 Source-Link: googleapis/googleapis@7837470 feat(functions): added support for CMEK docs: clarified wording around quota usage Clients can now specify the docker registry to use for storing function Docker images and KMS crypto keys for function source code objects. PiperOrigin-RevId: 453234231 Source-Link: googleapis/googleapis@d180952 feat(aiplatform): add monitor_window to ModelDeploymentMonitoringScheduleConfig proto in aiplatform v1/v1beta1 model_deployment_monitoring_job.proto PiperOrigin-RevId: 453226330 Source-Link: googleapis/googleapis@239db5e docs(contactcenterinsights): Updating comments PiperOrigin-RevId: 452751522 Source-Link: googleapis/googleapis@530ca55 feat(gkehub): Added support for locations and iam_policy clients PiperOrigin-RevId: 452647783 Source-Link: googleapis/googleapis@fbb5dd9 feat(spanner): add Session creator role docs: clarify transaction semantics PiperOrigin-RevId: 452634948 Source-Link: googleapis/googleapis@df51ec8 feat(compute): Update Compute Engine API to revision 20220526 (#722) Source-Link: googleapis/googleapis@950dd73
codyoss
pushed a commit
that referenced
this issue
Jun 13, 2022
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#823 Changes: chore(shell): add http rules for LROs PiperOrigin-RevId: 453261273 Source-Link: googleapis/googleapis@f8e97f9 fix(talent)!: remove Application and Profile services and and related protos, enums, and messages PiperOrigin-RevId: 453241222 Source-Link: googleapis/googleapis@7837470 feat(functions): added support for CMEK docs: clarified wording around quota usage Clients can now specify the docker registry to use for storing function Docker images and KMS crypto keys for function source code objects. PiperOrigin-RevId: 453234231 Source-Link: googleapis/googleapis@d180952 feat(aiplatform): add monitor_window to ModelDeploymentMonitoringScheduleConfig proto in aiplatform v1/v1beta1 model_deployment_monitoring_job.proto PiperOrigin-RevId: 453226330 Source-Link: googleapis/googleapis@239db5e docs(contactcenterinsights): Updating comments PiperOrigin-RevId: 452751522 Source-Link: googleapis/googleapis@530ca55 feat(gkehub): Added support for locations and iam_policy clients PiperOrigin-RevId: 452647783 Source-Link: googleapis/googleapis@fbb5dd9 feat(spanner): add Session creator role docs: clarify transaction semantics PiperOrigin-RevId: 452634948 Source-Link: googleapis/googleapis@df51ec8 feat(compute): Update Compute Engine API to revision 20220526 (#722) Source-Link: googleapis/googleapis@950dd73
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In https://github.com/GoogleCloudPlatform/google-cloud-go/blob/master/trace/trace.go it says:
// When a span created by SpanFromRequest or SpamFromHeader is finished, theI think this is meant to be SpanFromHeader.
The text was updated successfully, but these errors were encountered: