Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): add back DirectPath misconfiguration logging #11162

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(auth): add back DirectPath misconfiguration logging #11162

wants to merge 2 commits into from

Conversation

xmenxk
Copy link
Contributor

@xmenxk xmenxk commented Nov 20, 2024

@xmenxk xmenxk requested a review from a team as a code owner November 20, 2024 22:32
@xmenxk
Copy link
Contributor Author

xmenxk commented Nov 20, 2024

This follows the PR in googleapis/google-api-go-client#2225

@BrennaEpp
Copy link
Contributor

Is there something remaining for this PR to be ready?

@xmenxk
Copy link
Contributor Author

xmenxk commented Jan 13, 2025

Is there something remaining for this PR to be ready?

@codyoss ptal

codyoss
codyoss requested changes Jan 14, 2025
View reviewed changes
auth/grpctransport/directpath.go
@@ -137,15 +137,15 @@ func logDirectPathMisconfig(endpoint string, creds *auth.Credentials, o *Options

// Case 1: does not enable DirectPath
if !isDirectPathEnabled(endpoint, o) {
log.Println("WARNING: DirectPath is disabled. To enable, please set the EnableDirectPath option along with the EnableDirectPathXds option.")
slog.Warn("DirectPath is disabled. To enable, please set the EnableDirectPath option along with the EnableDirectPathXds option.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have a general logging pattern. Please access the logger via o.logger().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmenxk @BrennaEpp @codyoss