Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): implement Notification methods #6138

Merged
merged 13 commits into from
Jun 14, 2022
Merged

chore(storage): implement Notification methods #6138

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b9f8ea2
chore(storage): implement ListNotifications
cojenco Jun 2, 2022
09eb7a6
add create, get, delete notification ops
cojenco Jun 7, 2022
ee59533
merge main
cojenco Jun 8, 2022
90815c3
update ListNotifications implementation
cojenco Jun 8, 2022
d085bd1
update listNotifications to use InternalFetch
cojenco Jun 8, 2022
40f6fe4
address comments
cojenco Jun 9, 2022
139c853
review comments
cojenco Jun 10, 2022
c9797d8
remove GetNotification and address comments
cojenco Jun 10, 2022
b2a03d0
merge main
cojenco Jun 13, 2022
4acd6ab
update comments
cojenco Jun 13, 2022
66f3ecf
move tests
cojenco Jun 13, 2022
f898d0a
Merge branch 'main' into grpc-notif
cojenco Jun 14, 2022
a615ecd
Merge branch 'main' into grpc-notif
cojenco Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions storage/grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,17 +855,12 @@ func (c *grpcStorageClient) ListNotifications(ctx context.Context, bucket string
Parent: bucketResourceName(globalProjectAlias, bucket),
}
var notifications []*storagepb.Notification
var next string
err = run(ctx, func() error {
gitr := c.raw.ListNotifications(ctx, req, s.gax...)
for {
n, err := gitr.Next()
if err == iterator.Done {
break
}
if err != nil {
return err
}
notifications = append(notifications, n)
notifications, next, err = gitr.InternalFetch(20, "")
cojenco marked this conversation as resolved.
Show resolved Hide resolved
if next == "" {
return nil
}
return err
}, s.retry, s.idempotent, setRetryHeaderGRPC(ctx))
Expand Down