chore(bigtable): more text proxy tune-up #6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
quartzmo
reviewed
Nov 2, 2022
| @@ -507,15 +529,15 @@ type goTestProxyServer struct { | |||
|
|
|||
| // client retrieves a testClient from the clientIDs map. You must lock clientsLock before calling | |||
| // this method. | |||
There was a problem hiding this comment.
Maybe move this comment into an error message?
There was a problem hiding this comment.
You must lock clientsLock before calling this method.
There was a problem hiding this comment.
Ack. That makes sense, but is out-of-scope for this review. I'll consider your suggestion for future improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Client.Open()