Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/postprocessor): some refactoring and fixes #7477

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Feb 22, 2023

  • Updates tests to read from testdata files
  • Fixing some formatting issues that could arise in updated commit messages
  • Fixes linked bug
  • Updates lockfile to use this code

Fixes: #7474

@codyoss codyoss requested a review from a team as a code owner February 22, 2023 20:47
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 22, 2023
@codyoss codyoss requested a review from quartzmo February 22, 2023 20:48
@codyoss
Copy link
Member Author

codyoss commented Feb 22, 2023

Tried to split this up into logical commits to make it easier to review. I will have a followup PR to clean up more style things

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Feb 22, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 23, 2023
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Feb 23, 2023
internal/postprocessor/main.go Show resolved Hide resolved
@gcf-merge-on-green gcf-merge-on-green bot merged commit fa6bbe5 into googleapis:main Feb 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

post processor should not modify processed PRs
2 participants