-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix flaky IT test cases #8260
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9fb64e6
chore: Busy wait java-container CREATE operation to finish
lqiu96 c3edca8
chore: Delete any existing java-notebook instances
lqiu96 e6c548e
chore: Use ListInstanceRequest with parent
lqiu96 06d3f67
chore: Delete gapic compute instances
lqiu96 7ad0c30
chore: Use ZonedDateTime for RFC3339 with Zone
lqiu96 e77cefd
chore: Setup the correct Request object field
lqiu96 b466d5f
chore: Create new IT profile
lqiu96 704cd3c
chore: Move shared deps profile to root pom.xml
lqiu96 9c21c07
chore: Use test lifecycle phase for graalvm tests
lqiu96 056b2cd
chore: Use old pom configs
lqiu96 0ad9b28
chore: Use correct path to vision resources
lqiu96 06c618d
Merge branch 'main' into update_container_IT
lqiu96 c200945
chore: Remove unused pom.xml
lqiu96 3922ea7
chore: Move busy wait after CREATE operation
lqiu96 08a5645
chore: Add specific names for IT compute instances
lqiu96 7782c59
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] aaa73ba
chore: Clean up compute instances names
lqiu96 7ac0434
chore: Clean up instances
lqiu96 ad03253
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 2bfe213
chore: Add checks for deletion
lqiu96 24462f0
Merge branch 'update_container_IT' of github.com:googleapis/google-cl…
lqiu96 dd1bad5
chore: Add missing import
lqiu96 a99d4dd
chore: Add missing import for notebooks
lqiu96 b087f07
Merge branch 'main' into update_container_IT
lqiu96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
chore: Busy wait java-container CREATE operation to finish
- Loading branch information
commit 9fb64e644eeefc7c958dedb6acc24f337ea85217
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we waiting for cluster creation completion in
afterClass()
? Shouldn't we wait for it right after creation inbeforeClass()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to run operations of the client (get/ list) without the operation having to be complete. It was only when deleting the cluster, I got an error with
Operation in progress
. I think it would make sense to move this to wait when the operation was run.I'll change this to to do the busy wait in beforeClass().