-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add java17 profile in jar-parent for graalvm #8676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be deleted again by the scripts. Can we move it to the jar-parent?
I believe this is an |
We're trying to centralize the config. Since, it's only affecting tests, it should be fine in the parent. |
Sure, that makes sense. I'm sure there may be future modules that might run into this issue as well. Will update. |
Merge after @meltsufin releases monorepo (10/24) |
@lqiu96 CI 17 failed. PTAL. |
I'm seeing this error message in the logs:
Adding |
DialogFlow ITs are failing these two tests:
Looking at the past fusion logs, it has been happening for a while. Going to create a draft PR to investigate. |
I opened an issue for it: #8681. |
Add in java-os-login java 17 profile for GraalVM.
This was removed in #8637 and was a fix from @mpeddada1's old PR in split repo: googleapis/java-os-login#688