Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addressvalidation new module for addressvalidation #8763

Closed
wants to merge 4 commits into from

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Nov 10, 2022

Initial generation for new addressvalidation client library

Corrected from #8741

Generation script:

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=addressvalidation \
  --proto-path=google/maps/addressvalidation \
  --name-pretty="Address Validation API" \
  --product-docs="https://developers.google.com/maps/documentation/address-validation/" \
  --api-description="The Address Validation API allows developers to verify the accuracy of addresses. Given an address, it returns information about the correctness of the components of the parsed address, a geocode, and a verdict on the deliverability of the parsed address." \
  --api-id=addressvalidation.googleapis.com \
  --cloud-api=false \
  --requires-billing=true \
  --distribution-name="com.google.maps:google-maps-addressvalidation"

@suztomo
Copy link
Member

suztomo commented Nov 10, 2022

If your shell remembers it, can you copy-paste the command in the description of this pull request?

@suztomo
Copy link
Member

suztomo commented Nov 10, 2022

unmanaged versions check is failing.

11:    <version>1.5.3</version>
Found version declaration(s) without x-version-update in: ./java-addressvalidation/google-maps-addressvalidation-bom/pom.xml
---------------------------------------------------------
87:      <version>4.13.2</version>
Found version declaration(s) without x-version-update in: ./java-addressvalidation/google-maps-addressvalidation/pom.xml
---------------------------------------------------------
17:    <version>1.[5](https://github.com/googleapis/google-cloud-java/actions/runs/3438729968/jobs/5735166643#step:3:6).3</version>
[8](https://github.com/googleapis/google-cloud-java/actions/runs/3438729968/jobs/5735166643#step:3:9)8:        <version>3.0.4</version>
[12](https://github.com/googleapis/google-cloud-java/actions/runs/3438729968/jobs/5735166643#step:3:13)4:        <version>3.3.0</version>
151:        <version>3.4.0</version>
Found version declaration(s) without x-version-update in: ./java-addressvalidation/pom.xml

Checking.

@alicejli
Copy link
Contributor Author

Thanks for digging in Tomo - I thought it was related to the same issue here: googleapis/synthtool#1707?

@alicejli
Copy link
Contributor Author

Closing as this was added here: #8850

@alicejli alicejli closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants