New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fixing stuff and root_versions script #8774

Merged

ddixit14 merged 1 commit into main from monorepo-fix

Nov 14, 2022

Contributor

ddixit14 commented Nov 14, 2022

This PR is doing three fixes:

java-dns artifact was not getting updated in the release-pr (because google-cloud-dns artifact was not present in root versions.txt) so fixed it.
java-kms pom.xml annotation was wrong for one artifact, fixed it.
Fixed generate_root_versions_txt.sh because we no longer have versions.txt in each module, only the newly generated modules will have it. Now we need to run this only as a part of generating new-module.


          chore: Fixing some stuff

ddixit14 requested review from suztomo and meltsufin

November 14, 2022 15:07

suztomo approved these changes

View reviewed changes

ddixit14 merged commit 6ca1f65 into main

ddixit14 deleted the monorepo-fix branch

November 14, 2022 18:26

alicejli pushed a commit that referenced this pull request


          chore: Fixing some stuff (#8774)

b8546e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet