chore: excluding java-maps-* modules #8776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddixit14
approved these changes
Nov 14, 2022
|
b/247780706, where groupId needs to be discussed further. |
|
@suztomo Can you just add skip deploy config? |
|
@meltsufin I prefer removing the module from the root to figuring out the proper configuration to exclude. It's simpler than modifying pom.xml files. As you know Maven nexus deploy configuration is not simple. (Question about "-bom", "grpc-", and "proto-" artifacts). |
|
Talked with Mike. Deleting the module. We will regenerate the module once groupID is set. |
suztomo
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
meltsufin
reviewed
Nov 14, 2022
generation/print_root_pom.sh
Outdated
| @@ -8,4 +8,6 @@ GENERATION_DIR=$(dirname -- "$0"); | |||
| find . -mindepth 2 -maxdepth 2 -name pom.xml |sort --dictionary-order | xargs dirname \ | |||
| |sed -e 's|./||' | xargs -I '{}' echo " <module>{}</module>" > /tmp/repo-modules.txt | |||
|
|
|||
| sed -i.bak '/java-maps/d' /tmp/repo-modules.txt | |||
There was a problem hiding this comment.
No need for this anymore, right?
meltsufin
approved these changes
Nov 14, 2022
suztomo
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
alicejli
pushed a commit
that referenced
this pull request
Nov 15, 2022
GroupId needs to be discussed further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupId needs to be discussed further.