Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [container] add compact placement feature for node pools #8786

Merged
merged 2 commits into from
Nov 17, 2022
Merged

feat: [container] add compact placement feature for node pools #8786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c0345d
feat: add compact placement feature for node pools
gcf-owl-bot[bot] Nov 16, 2022
ce7aec3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions java-container/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ If you are using Maven, add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-container</artifactId>
<version>2.8.0</version>
<version>2.9.0</version>
</dependency>
```

If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-container:2.8.0'
implementation 'com.google.cloud:google-cloud-container:2.9.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-container" % "2.8.0"
libraryDependencies += "com.google.cloud" % "google-cloud-container" % "2.9.0"
```

## Authentication
Expand Down Expand Up @@ -159,16 +159,16 @@ Java is a registered trademark of Oracle and/or its affiliates.

[product-docs]: https://cloud.google.com/kubernetes-engine/
[javadocs]: https://cloud.google.com/java/docs/reference/google-cloud-container/latest/overview
[kokoro-badge-image-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java7.svg
[kokoro-badge-link-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java7.html
[kokoro-badge-image-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java8.svg
[kokoro-badge-link-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java8.html
[kokoro-badge-image-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java8-osx.svg
[kokoro-badge-link-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java8-osx.html
[kokoro-badge-image-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java8-win.svg
[kokoro-badge-link-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java8-win.html
[kokoro-badge-image-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java11.svg
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-container/java11.html
[kokoro-badge-image-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java7.svg
[kokoro-badge-link-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java7.html
[kokoro-badge-image-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java8.svg
[kokoro-badge-link-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java8.html
[kokoro-badge-image-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java8-osx.svg
[kokoro-badge-link-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java8-osx.html
[kokoro-badge-image-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java8-win.svg
[kokoro-badge-link-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java8-win.html
[kokoro-badge-image-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.svg
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-container.svg
[maven-version-link]: https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-cloud-container&core=gav
Expand All @@ -180,9 +180,9 @@ Java is a registered trademark of Oracle and/or its affiliates.
[create-project]: https://cloud.google.com/resource-manager/docs/creating-managing-projects
[cloud-sdk]: https://cloud.google.com/sdk/
[troubleshooting]: https://github.com/googleapis/google-cloud-common/blob/main/troubleshooting/readme.md#troubleshooting
[contributing]: https://github.com/googleapis/java-container/blob/main/CONTRIBUTING.md
[code-of-conduct]: https://github.com/googleapis/java-container/blob/main/CODE_OF_CONDUCT.md#contributor-code-of-conduct
[license]: https://github.com/googleapis/java-container/blob/main/LICENSE
[contributing]: https://github.com/googleapis/google-cloud-java/blob/main/CONTRIBUTING.md
[code-of-conduct]: https://github.com/googleapis/google-cloud-java/blob/main/CODE_OF_CONDUCT.md#contributor-code-of-conduct
[license]: https://github.com/googleapis/google-cloud-java/blob/main/LICENSE

[enable-api]: https://console.cloud.google.com/flows/enableapi?apiid=container.googleapis.com
[libraries-bom]: https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM
Expand Down
2 changes: 2 additions & 0 deletions ...cloud-container/src/test/java/com/google/cloud/container/v1/ClusterManagerClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2049,6 +2049,7 @@ public void getNodePoolTest() throws Exception {
.addAllConditions(new ArrayList<StatusCondition>())
.setPodIpv4CidrSize(1098768716)
.setUpgradeSettings(NodePool.UpgradeSettings.newBuilder().build())
.setPlacementPolicy(NodePool.PlacementPolicy.newBuilder().build())
.setUpdateInfo(NodePool.UpdateInfo.newBuilder().build())
.build();
mockClusterManager.addResponse(expectedResponse);
Expand Down Expand Up @@ -2102,6 +2103,7 @@ public void getNodePoolTest2() throws Exception {
.addAllConditions(new ArrayList<StatusCondition>())
.setPodIpv4CidrSize(1098768716)
.setUpgradeSettings(NodePool.UpgradeSettings.newBuilder().build())
.setPlacementPolicy(NodePool.PlacementPolicy.newBuilder().build())
.setUpdateInfo(NodePool.UpdateInfo.newBuilder().build())
.build();
mockClusterManager.addResponse(expectedResponse);
Expand Down
14 changes: 7 additions & 7 deletions ...-container-v1/src/main/java/com/google/container/v1/AutoprovisioningNodePoolDefaults.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public com.google.container.v1.NodeManagementOrBuilder getManagementOrBuilder()
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @return The minCpuPlatform.
*/
@java.lang.Override
Expand Down Expand Up @@ -340,7 +340,7 @@ public java.lang.String getMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @return The bytes for minCpuPlatform.
*/
@java.lang.Override
Expand Down Expand Up @@ -1842,7 +1842,7 @@ public com.google.container.v1.NodeManagementOrBuilder getManagementOrBuilder()
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @return The minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -1878,7 +1878,7 @@ public java.lang.String getMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @return The bytes for minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -1914,7 +1914,7 @@ public com.google.protobuf.ByteString getMinCpuPlatformBytes() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @param value The minCpuPlatform to set.
* @return This builder for chaining.
*/
Expand Down Expand Up @@ -1949,7 +1949,7 @@ public Builder setMinCpuPlatform(java.lang.String value) {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @return This builder for chaining.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -1980,7 +1980,7 @@ public Builder clearMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @param value The bytes for minCpuPlatform to set.
* @return This builder for chaining.
*/
Expand Down
4 changes: 2 additions & 2 deletions ...r-v1/src/main/java/com/google/container/v1/AutoprovisioningNodePoolDefaultsOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @return The minCpuPlatform.
*/
@java.lang.Deprecated
Expand All @@ -216,7 +216,7 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3398
* deprecated. See google/container/v1/cluster_service.proto;l=3418
* @return The bytes for minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down
Loading